Draft
Conversation
Collaborator
Author
|
Draft PR: I am still waiting for some tests on Alps, which is under maintenance. |
Collaborator
Author
|
Checked with alps, produces correct results even when forcing a load balancing call after 5 time-steps, multi-GPU (2 and 4 GPUs checked). |
Collaborator
Author
|
Lumi not ok: 8 GPUs fine, 16 GPUs wrong results. Looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #485
The issue is that after load balancing, the FEM space used by the solver does not update its partitioning of the element indices among ranks according to the new domain decomposition, and the member variable resultField_m also needs to update its layout.
This issue was correctly identified by the AI tool Hugo in #487, but not properly fixed (fixed the symptom instead of the cause).
To fix this properly, a new
updateLayoutmember function is introduced in the LagrangeSpace, which is called by the LoadBalancer in alpine if using the FEM solver, in the same way that theupdateLayoutof the fields works in the LoadBalancer. This means that every time load balancing is done and the domain decomposition changes, the LagrangeSpace takes the new domain decomposition into account and repartitions the elements too.