Fix zero-copy push#1489
Merged
Merged
Conversation
zero-copy of numpy arrays only applies to first-level in args/kwargs, but push took a dict as arg. This simply changes push to pass the same ns as kwargs, so numpy arrays will be discovered.
minrk
added a commit
that referenced
this pull request
Mar 25, 2012
Fix zero-copy push zero-copy of numpy arrays only applies to first-level in args/kwargs, but push took a dict as arg. This simply changes push to pass the same ns as kwargs, so numpy arrays will be properly recognized by the serialization machinery.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix zero-copy push zero-copy of numpy arrays only applies to first-level in args/kwargs, but push took a dict as arg. This simply changes push to pass the same ns as kwargs, so numpy arrays will be properly recognized by the serialization machinery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zero-copy of numpy arrays only applies to first-level in args/kwargs, but push took a dict as arg. This simply changes push to pass the same ns as kwargs, so numpy arrays will be properly recognized by the serialization machinery.
Test included.