Remove importlib dependency which not available in Python 2.6.#1882
Conversation
Since we are only doing an absolute import, it suffices to just run `__import__(name)` and then find the module in `sys.modules`. Closes ipython#1874.
|
Thanks, Brad. This fix looks clean if we don't expect relative imports to be made here, since that's what the omitted |
|
Yep, and we certainly wouldn't be using relative imports here. |
|
Test results for commit 7067c17 merged into master
Not available for testing: |
|
Mmh, I'm getting that failure above, but I'm also seeing problems on master right now. How about you guys? This PR actually looks clean, but I'd prefer to get master back in passing shape before doing any more merging... |
|
Actually, this is really too simple to block on, let's go ahead. Thanks @bfroehle! My worry on master remains, but that's a separate problem. |
Remove importlib dependency which not available in Python 2.6. Since we are only doing an absolute import, it suffices to just run __import__(name) and then find the module in sys.modules. Closes #1874.
|
@fperez: i'm seeing that same error, fwiw |
|
On Thu, Jun 7, 2012 at 9:59 PM, Paul Ivanov
Mmh, ok... We'll have to get master in shape soon then, thanks! f |
Remove importlib dependency which not available in Python 2.6. Since we are only doing an absolute import, it suffices to just run __import__(name) and then find the module in sys.modules. Closes ipython#1874.
Since we are only doing an absolute import, it suffices to just run
__import__(name)and then find the module insys.modules.Compare to the
import_modulesource:Closes #1874.