complete on % for magic in notebook

[Carreau]

fixes 3954

Ping @ivanov, just to be sure it does not break master.

[ivanov]

this doesn't quite work - it'll offer the completions the first time, but pressing tab again takes me to the browser location bar, and after that I start to just tab through all of the clickable links on the page.

[Carreau]

That was just an edge case of the completer crashing. Tab a second time should just 'repop' the completer now.

[ivanov]

I don't know this javascript stuff, but this works :1: l

[Carreau]

I don't know this javascript stuff, but this works :1: l

Don't even try to understand. The completion result should not be just a string, it should be a mixed dict of result from kernel and info for codemirror.

Target 2.0 ? or 1.0 ?

[minrk]

2.0, I think. Even though it seems trivial, we have to draw the line somewhere.

[ivanov]

so long as its merged and fixed in master shortly, we won't know the difference anyway, right? ;)

[Carreau]

Merging in, in anyway this is one thing that will probably need refactor. Especially if we have dual mode.