setup.py changes for 2.0#4975
Merged
Merged
Conversation
Member
|
#4893 is in - Min, do you want to rebase and update the location of FA? |
Member
There was a problem hiding this comment.
Would it be cleaner to just make these always lists, even if they have just one element?
Member
|
Besides the expected distutils mess, I think this looks OK. |
and only check for it on posix
results in 'py2-none-any' instead of 'py27-none-any'. This is supported by pip and PEP 425, but not available from bdist_wheel by default.
in bdist_wheel
we don't need most of what's in components to be installed. Much of it is included just for sdists or development.
let the function reflect this, rather than having several entries with no files.
because an empty distutils command must implement three no-op methods and one class attribute. Which makes perfect sense.
and fix errors caught by the validation
simpler, that way
Member
|
Min's dealt with my suggestions, so I'm merging this now so people have time to spot any flaws in it before release. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
setup.py changes for 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main point of this PR:
IPython source distributions are growing, due to the inclusion of many javascript dependencies. A large portion of these files are not actually used at install time, so a bdist (wheel) can be much smaller than an sdist. Currently, testing this PR shows a wheel being 3.3MB, while an sdist is 9MB.
Notes:
This should be rebased after #4893 is merged, since it moves font-awesome.
We are currently only shipping manpages to usr/share, but the function that does this also claims to install examples, but it doesn't because the search path is wrong. I removed the failing code,
but I could just as easily fix it to actually install examples, if that is what we want it to do.
Still testing to do, to make sure the whitelist isn't too exclusive.
The ickiest part of the changes required is mangling
Requires-Dist, for turning old-style requirements into PEP-345Requires-Dist, which is the only way to specify platform-specific dependencies. Only wheels actually support PEP-345, so we have to specify these requirements in at least two places. This was the smallest change I could come up with, with the minimal code duplication.Bonus wtf points for discovering that PKG_INFO is an instance of
email.Message(?!)