Skip to content

CodeMirror shortcuts in QuickHelp#5436

Merged
minrk merged 8 commits into
ipython:masterfrom
ivanov:cm-shorcuts-quickhelp
Mar 31, 2014
Merged

CodeMirror shortcuts in QuickHelp#5436
minrk merged 8 commits into
ipython:masterfrom
ivanov:cm-shorcuts-quickhelp

Conversation

@ivanov
Copy link
Copy Markdown
Member

@ivanov ivanov commented Mar 26, 2014

Our users shouldn't need an internet connection to look at the code mirror
shortcuts. This PR places the CM keyboard shortcuts that are currently
documented on our website's rendered docs, and places them inside the keyboard
shortcuts quickhelp.

Our users shouldn't need an internet connection to look at the code
mirror shortcuts. This PR places the CM keyboard shortcuts that are
currently documented on our website's rendered docs, and places them
inside the keyboard shortcuts quickhelp.
@ivanov
Copy link
Copy Markdown
Member Author

ivanov commented Mar 26, 2014

I'll add logic for the PC/Mac shortcuts to this, just wanted to open the PR

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake?

@ivanov
Copy link
Copy Markdown
Member Author

ivanov commented Mar 28, 2014

Ok, I think this is ready to go, here's what it looks like:

2014-03-27-171944_673x312_scrot

@ivanov
Copy link
Copy Markdown
Member Author

ivanov commented Mar 28, 2014

perhaps I should distinguish the undo and redo in CM from undo and redo in command mode? "undo text edit" and "redo text edit" or something like that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like PageUp, PageDown, Home and End can be moved out of platform_specific.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is true, but i kept them here to keep them next to the other keys which perform the same function.

@minrk
Copy link
Copy Markdown
Member

minrk commented Mar 29, 2014

perhaps I should distinguish the undo and redo in CM from undo and redo in command mode? "undo text edit" and "redo text edit" or something like that.

I would do it the other way around - undo in command mode is really 'undo delete cell'. There are no other actions that can be undone in command mode.

@minrk minrk changed the title WIP: CodeMirror shortcuts in QuickHelp CodeMirror shortcuts in QuickHelp Mar 31, 2014
minrk added a commit that referenced this pull request Mar 31, 2014
@minrk minrk merged commit 1ebcc42 into ipython:master Mar 31, 2014
@minrk minrk deleted the cm-shorcuts-quickhelp branch March 31, 2014 21:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants