Fix auto formatting to be called only once.#12336
Merged
Merged
Conversation
There seem to be a small race-condition when trying to reformat the text
twice in a short amount of time where some of the non-changed test
diapear. For example
async def b():pass
Lead to two reformatting where one does not see the `async` keyword
anymore., and would thus dedent the def by 1 space.
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seem to be a small race-condition when trying to reformat the text
twice in a short amount of time where some of the non-changed test
diapear. For example
Lead to two reformatting where one does not see the
asynckeywordanymore., and would thus dedent the def by 1 space.