Fix and test for "async with does not allow new lines".#13436
Merged
Conversation
Use the opportunity to add a test, and parametrise a few other, plus set the correct stacklevel. Closes ipython#12975
Carreau
force-pushed
the
fix-async-with
branch
from
60297b2 to
cb6563d
Compare
naterush
approved these changes
Jan 12, 2022
Contributor
naterush
left a comment
naterush
left a comment
There was a problem hiding this comment.
@Carreau I'm new here, so not sure what the etiquette is on reviews. You mentioned elsewhere you're the main PR reviewer, so thought I'd try to help out on your PRs. If it's not helpful (or there's a more helpful way to be involved), please let me know.
I've verified these changes move the reporting of the warning to the call site of make_tokens_by_line, which seems to be the primary goal of this PR. LGTM ::))
Member
Author
|
Thanks, that is helpful review. Even a LGTM, and making sure I don't forget a print statement or anything else is welcome. |
lumberbot-app
Bot
added
the
Still Needs Manual Backport
Carreau
removed
the
Still Needs Manual Backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the opportunity to add a test, and parametrise a few other, plus set
the correct stacklevel.
Closes #12975