Skip to content

Fix for failing testsuite when using --with-xml-coverage on windows.#1440

Merged
minrk merged 2 commits into
ipython:masterfrom
jstenar:win32-testing
Mar 8, 2012
Merged

Fix for failing testsuite when using --with-xml-coverage on windows.#1440
minrk merged 2 commits into
ipython:masterfrom
jstenar:win32-testing

Conversation

@jstenar
Copy link
Copy Markdown
Contributor

@jstenar jstenar commented Feb 26, 2012

This is necessary to get the shiningpanda testing on windows to work. Without the fix all tests fail. Using this fix I ran the tests and the results are up on:
https://jenkins.shiningpanda.com/ipython/job/ipython-windows-py27/1/

See #1428 for discussion.

@takluyver
Copy link
Copy Markdown
Member

If we really can get rid of this, then we no longer need the sys.platform test either.

@minrk
Copy link
Copy Markdown
Member

minrk commented Mar 8, 2012

Is this ready, then? Does it close #1428?

@takluyver
Copy link
Copy Markdown
Member

I think it's ready (if @jstenar is happy that it works), but it doesn't close #1428. This was an issue for running the test suite itself, #1428 is a failure on a specific test.

@minrk
Copy link
Copy Markdown
Member

minrk commented Mar 8, 2012

okay, then.

minrk added a commit that referenced this pull request Mar 8, 2012
Fix for failing testsuite when using --with-xml-coverage on windows.

This is necessary to get the shiningpanda testing on windows to work. Without the fix all tests fail.
@minrk minrk merged commit 6ab07eb into ipython:master Mar 8, 2012
@jstenar
Copy link
Copy Markdown
Contributor Author

jstenar commented Mar 8, 2012

Thomas skrev 2012-03-08 01:29:

I think it's ready (if @jstenar is happy that it works), but it doesn't close #1428. This was an issue for running the test suite itself, #1428 is a failure on a specific test.

As far as I can tell it works. Thomas is right this is a fix to get the
testsuite running.

/Jörgen

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Fix for failing testsuite when using --with-xml-coverage on windows.

This is necessary to get the shiningpanda testing on windows to work. Without the fix all tests fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants