Add custom_control and custom_page_control variables to override the Qt widgets used by qtconsole#2007
Conversation
ccordoba12
commented
Jun 22, 2012
ccordoba12
commented
- This will let other project to easily provide its own widgets
- Try to fix Provide an easy way to override the Qt widget used by qtconsole #1920
…Qt widgets used by qtconsole - This will let other project to easily provide its own widgets - Try to fix ipython#1920
|
@fperez, I tried this approach in conjunction with Spyder and it works great, letting us easily use our subclass of QTextEdit. |
There was a problem hiding this comment.
Shouldn't this be a callable? control = self.custom_control()
There was a problem hiding this comment.
I was planning to use it as: self.custom_control = SpyderControlWidget() but I think you're right. It would better match how you create control in the next line. I'm going to change it.
|
Looks fine to me. Handing it on to bleeding edgers for a look as well. |
- This better matches how they are normally created
|
This looks fine to me now, so when we get one more OK from @jdmarch's beeding edgers, it's ready to go. |
|
Targeting for 0.13 then, @jdmarch let us know how things go so we can squeeze this one in before release. |
|
Got the ok - thanks @punchagan |
|
Great, thanks! Merging now then. |
Add custom_control and custom_page_control variables to override the Qt widgets used by qtconsole. This will let other project to easily provide its own widgets, the work was driven by better Spyder integration with IPython, but can benefit other tools as well. Closes #1920.
|
Thanks guys for your support and to Enthought guys for giving their OK. |
Add custom_control and custom_page_control variables to override the Qt widgets used by qtconsole. This will let other project to easily provide its own widgets, the work was driven by better Spyder integration with IPython, but can benefit other tools as well. Closes ipython#1920.
4 participants
