Fix IPython.lib.latextools for Python 3#2189
Merged
Merged
Conversation
Member
Author
|
Test results for commit 0043a0d merged into master
Not available for testing: python2.6 |
Member
Author
|
I'll give people a day for any objections, then merge this. |
Member
|
ok with me. |
Member
|
Looks solid to me, thanks for cleaning up! |
Member
Author
|
Thanks Matthias & Min. I'll merge this now then, so that we can get clean test runs from test_pr again. |
takluyver
added a commit
that referenced
this pull request
Jul 23, 2012
Fix IPython.lib.latextools for Python 3
Member
|
Perfect, we are staying under 40 opened PRs ... :-) |
Member
Author
|
It'd be good to have a blitz and see if we could get it down to ~10, but new ones come in so fast that I don't know if that's possible. |
Member
|
We already had a blitz, it was SciPy... |
Member
|
I know - I closed a bunch on Friday night, but they were coming in as fast as I could close them. |
Member
|
15 merged PR on the 20 looking at the graph... |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix IPython.lib.latextools for Python 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't quite being careful enough about binary data. This also adds a couple of tests for functions that were missing coverage.
(Test failures seen testing another PR: https://gist.github.com/3163508 )