Skip to content

add IPython version to message headers#2407

Merged
bfroehle merged 2 commits into
ipython:masterfrom
minrk:sessionversion
Sep 18, 2012
Merged

add IPython version to message headers#2407
bfroehle merged 2 commits into
ipython:masterfrom
minrk:sessionversion

Conversation

@minrk
Copy link
Copy Markdown
Member

@minrk minrk commented Sep 14, 2012

will allow future logic to make appropriate compatibility checks

always-comparable tuple for IPython versions

Note that types for each slot must never differ, due to Python 3 breaking loose comparisons (0 is used for base micro, never '')
Comment thread IPython/zmq/session.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NameError: global name 'IPython' is not defined

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I forgot I had made a pull request from this. Fixed.

will allow future logic to make appropriate compatibility checks
@Carreau
Copy link
Copy Markdown
Member

Carreau commented Sep 15, 2012

Ok for merge.
I'll let it open if SO else want to have a look, otherwise if you need go ahead and merge it.

bfroehle added a commit that referenced this pull request Sep 18, 2012
add IPython version to message headers
@bfroehle bfroehle merged commit 5cd5d18 into ipython:master Sep 18, 2012
@bfroehle
Copy link
Copy Markdown
Contributor

Looks good to me. Merged.

@minrk minrk deleted the sessionversion branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
add IPython version to message headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants