Windows aware tests for shellglob#2529
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
For clarity, can this subclass unittest.TestCase?
Contributor
Author
There was a problem hiding this comment.
No, we can't subclass unittest.TestCase if we want to use test generators, as unittest does not support test generator.
Contributor
Author
|
@takluyver sorry about the contextmanager. it's fixed. |
Member
|
Great, thanks. have you run these tests on Windows? |
Contributor
Author
|
Right, should be clarified. No, I haven't run them as I don't have windows box. |
Member
|
Well, let's just merge it so it gets included in the next ShiningPanda run. We can always revise it later. Thanks again. |
takluyver
added a commit
that referenced
this pull request
Oct 29, 2012
Windows aware tests for shellglob
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Windows aware tests for shellglob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully fixes the other half of #2477