base default cookie name on request host+port#3372
Merged
Conversation
instead of random. The random cookie name meant that every time you restarted the notebook it would get a new key in the cookie for the same host, resulting in an ever-growing cookie full of obsolete data.
minrk
added a commit
to minrk/ipython
that referenced
this pull request
May 28, 2013
allows config to specify logins that survive across server instances (default behavior unchanged). Depends on PR ipython#3372
Member
|
how would this behave with multiple server on same machine ? |
Member
|
Ho, |
Member
Author
|
each server would get a different cookie (just like now), but the keys would have names like |
Member
Yes I figured out with the |
Member
Author
right, |
Member
|
Merging soon if no objection. |
Carreau
added a commit
that referenced
this pull request
Jun 2, 2013
base default cookie name on request host+port
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
allows config to specify logins that survive across server instances (default behavior unchanged). Depends on PR ipython#3372
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
base default cookie name on request host+port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of random.
The random cookie name meant that every time you restarted the notebook it would get a new key in the cookie for the same host, resulting in an ever-growing cookie full of obsolete data.