Skip to content

BF: fix nbconert rst input prompt spacing#3981

Merged
ivanov merged 1 commit into
ipython:masterfrom
matthew-brett:rst-nbconvert-fix
Aug 10, 2013
Merged

BF: fix nbconert rst input prompt spacing#3981
ivanov merged 1 commit into
ipython:masterfrom
matthew-brett:rst-nbconvert-fix

Conversation

@matthew-brett
Copy link
Copy Markdown
Contributor

I believe this fixes gh-3980

@ivanov
Copy link
Copy Markdown
Member

ivanov commented Aug 10, 2013

I can confirm that this fixes things, and the test suite passes locally. Thanks for the fix, Matthew. As soon as Travis greenlights this, I'll merge

@ivanov
Copy link
Copy Markdown
Member

ivanov commented Aug 10, 2013

pinged @damianavila who was the one to last change this portion of the template, according to git blame

@jdfreder
Copy link
Copy Markdown
Contributor

👍

@damianavila
Copy link
Copy Markdown
Member

It is ok for me... probably I misses that... go ahead.

ivanov added a commit that referenced this pull request Aug 10, 2013
BF: fix nbconert rst input prompt spacing
@ivanov ivanov merged commit e8f7aef into ipython:master Aug 10, 2013
ivanov pushed a commit that referenced this pull request Aug 10, 2013
BF: fix nbconert rst input prompt spacing

I believe this fixes gh-3980

backported and pushed into 1.x branch by @ivanov
@ivanov
Copy link
Copy Markdown
Member

ivanov commented Aug 10, 2013

ok, backported this into 1.x branch as well

@minrk
Copy link
Copy Markdown
Member

minrk commented Aug 10, 2013

@ivanov we have a backport_pr script in tools

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
BF: fix nbconert rst input prompt spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nbconvert rst output lacks needed blank lines

5 participants