fixes #4039.#4253
Merged
Merged
Conversation
Issues is that $(selector).val() return the associated text if no data is present (hence one cannot associate explicitely an option to "undefined") fix in doc and example.
Member
|
I don't think we have any problems, but I will test it and let you know... ;-) |
Member
|
This looks good, but let's wait until @damianavila has tested. |
Member
|
My tests go well... if anything happens we can make a PR later ;;-)... so +1 for merge this one.. |
Member
Author
|
Computer dead, but hopefully github now have merge button on phone! Merging! |
Carreau
added a commit
that referenced
this pull request
Sep 26, 2013
fixes #4039. Issues is that $(selector).val() return the associated text if no data is present (hence one cannot associate explicitely an option to "undefined") fix in doc and example.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fixes ipython#4039. Issues is that $(selector).val() return the associated text if no data is present (hence one cannot associate explicitely an option to "undefined") fix in doc and example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues is that $(selector).val() return the associated text if no data
is present (hence one cannot associate explicitely an option to
"undefined")
fix in doc and example.
Ping @damianavila that might be affected by this slight change, but shouldn't has we were obviously already storing '-' in metadata.