Implement boundary option for load magic (#1093) #4295
Conversation
There was a problem hiding this comment.
I'm not sure the comment here match the regex below.
There was a problem hiding this comment.
you are right. a careless copy&paste. fixing.
|
I'm wondering wether there is some code that could be share/factored from Just wondering. |
|
Thanks @Carreau . as I thought the same thing I decided implement an independent extract_code_ranges and don't touch history.py . |
|
Nice addition... and looks good. |
|
+1 too. |
There was a problem hiding this comment.
Looks like you have an editor configured to strip whitespace in blocks you are not actually editing. Can you rebase without these unhelpful changes?
|
Looks good to me, after rebasing without the large whitespace changes. This is fairly straightforward with: alias git-rebase-nows='git rebase -i --exec="git format-patch -w HEAD^1 --stdout | sh -c \"git reset HEAD^1 --hard; git am -\""'
git-rebase-nows origin/master |
|
@minrk the alias trick didn't work for me. (I got hope this would be ok. I'll config the editor/git to avoid this unhelpful changes. |
|
Great! Much cleaner now... |
|
Please, could you review mgaitan/ipython@d4d4726 . I feel more comfortable with python than with english :) |
|
Sorry if my example didn't work for you, may be a git version issue, or maybe I pasted it wrong. Anyway, thanks for your patience, merging now. |
Implement boundary option for load magic `%load -r 1-10` now does what one should expect. closes #1093
Implement boundary option for load magic `%load -r 1-10` now does what one should expect. closes ipython#1093
This is an implementation of #1093. Usage example is in this notebook
http://nbviewer.ipython.org/6746907