remove hardcoded box-orient#4355
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
You have a vbox here and there is another one in the 5 line (at the codecell block)
Member
Author
There was a problem hiding this comment.
This one is present in current notebook-app DOM. So I'm reluctant in removing it.
I'll re-check for the other one, but I was carefull to remove only the one that were already removed in the notebook app itself.
Member
Author
There was a problem hiding this comment.
Actually I think @damianavila was right for the other vbox in the codecell block, that does not exist in notebook-app.
I'll see if I can get rid of the last vboxes in js to and submit yet another PR that totally get rid of hardcoded h- and v-boxes both in templates and javascript.
Member
|
+1 for me... |
minrk
added a commit
that referenced
this pull request
Oct 7, 2013
remove hardcoded box-orient remove some hardcoded vbox and hbox in html templates, those are not anymore in the notebook-app DOM, in favor oh having the less class inheriting from the corresponding mixin. This should allow easier pure-css customization.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
remove hardcoded box-orient remove some hardcoded vbox and hbox in html templates, those are not anymore in the notebook-app DOM, in favor oh having the less class inheriting from the corresponding mixin. This should allow easier pure-css customization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove some hardcoded
vboxandhboxin html templates, those are not anymore in the notebook-app DOM, in favor oh having thelessclass inheriting from the corresponding mixin.This should allow easier pure-css customization.