Skip to content

Nbconvert latex markdown images2#4505

Merged
minrk merged 4 commits into
ipython:masterfrom
mrmagooey:nbconvert-latex-markdown-images2
Dec 17, 2013
Merged

Nbconvert latex markdown images2#4505
minrk merged 4 commits into
ipython:masterfrom
mrmagooey:nbconvert-latex-markdown-images2

Conversation

@mrmagooey
Copy link
Copy Markdown
Contributor

New PR to address #4191 (previous PR #4192 had fallen too far behind master)

@minrk
Copy link
Copy Markdown
Member

minrk commented Nov 13, 2013

This logic should probably be added to the already existing strip_files_prefix filter (which only handles HTML right now, not markdown links added here), rather than adding a new one.

@minrk
Copy link
Copy Markdown
Member

minrk commented Nov 13, 2013

and it shouldn't be image-specific

@minrk
Copy link
Copy Markdown
Member

minrk commented Nov 16, 2013

make sure to add a test for this is a [regular link](files/something) in markdown.

@minrk
Copy link
Copy Markdown
Member

minrk commented Nov 16, 2013

also, feel free to ping when you push and feel ready for re-review. There aren't notifications when you push commits, only comments.

minrk added a commit that referenced this pull request Dec 17, 2013
@minrk minrk merged commit 544353b into ipython:master Dec 17, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
…wn-images2

files url handling in nbconvert

closes ipython#4191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants