remove shift-= merge keyboard shortcut

[ptone]

The merge below was duplicated for two keyboard shortcuts, I assume one was meant to be merge above.

I wasn't sure if the help_index needed to change as well

[takluyver]

I think that was deliberate - the shortcuts with punctuation characters can be problematic on non US keyboards, so we made an alphabetic alternative.

[ellisonbg]

Actually this came from a different point and is deliberate. Originally we used shift+= for the merge below action. But on non-US keyboards that doesn't work. Thus we added shift+m for those with no-US keyboard, but wanted to keep the old one. We are trying to keep all our major shortcuts to the keys that most keyboard have in common. Give this, can we close this one?

[ptone]

OK - that is background I was clearly missing. It is a bit confusing when you see it - could the shift+= one be deprecated, or could the help text for one of them have "(alternate shortcut)" added?

[minrk]

We don't need to deprecate things, since we don't have a release with this yet. If we don't think shift+= is a good idea, we can just remove it.

[damianavila]

Probably, we can just remove it... I think that shift+m (one shortcut) is enough and the other alternative can be problematic... if we remove it, we will avoid further explanations like: "oh, for non-US keyboard..."

[ellisonbg]

Ok I will remove it.

On Fri, Jan 31, 2014 at 10:58 AM, Damián Avila notifications@github.comwrote:

Probably, we can just remove it... I think that shift+m (one shortcut) is
enough and the other alternative can be problematic... if we remove it, we
will avoid further explanations like: "oh, for non-US keyboard..."

Reply to this email directly or view it on GitHubhttps://github.com//pull/4964#issuecomment-33831318
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

Or actually, can you just remove the shift+= shortcut in this branch and put the action of shift+m back to its original.

[ivanov]

put the action of shift+m back to its original.

isn't shift+m already what it is supposed to be, so just removing shift+= should be enough

[ellisonbg]

It is not enough because we want to also remove shift+= which is in
master.

On Fri, Jan 31, 2014 at 3:06 PM, Paul Ivanov notifications@github.comwrote:

put the action of shift+m back to its original.

isn't shift+m already what it is supposed to be, so just closing this PR
is enough?

Reply to this email directly or view it on GitHubhttps://github.com//pull/4964#issuecomment-33851869
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ivanov]

sorry, I mistyped originally, Brian, just wanted to confirm that nothing needed to be changed with shift+m (I changed the end of my sentence to be so just removing shift+= should be enough so we do still need a PR for that)

[ellisonbg]

Ahh, yes this is correct.

On Fri, Jan 31, 2014 at 3:14 PM, Paul Ivanov notifications@github.comwrote:

sorry, I mistyped originally, Brian, just wanted to confirm that nothing
needed to be changed with shift+m (I changed the end of my sentence to be so
just removing shift+= should be enough so we do still need a PR for that)

Reply to this email directly or view it on GitHubhttps://github.com//pull/4964#issuecomment-33852420
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ptone]

OK, I force pushed the removal for a cleaner merge.

I think I misread the meaning of "originally" as being some form of established shortcut in released versions (I wasn't positive if non-modal notebook may have supported a few shortcuts), hence my comment of deprecation.

[ivanov]

thanks @ptone, I've re-titled the issue to describe the change we ended up going with here. merging!