FF Fix: alignment and scale of text widget#5037
Conversation
|
Hmm, the test of Travis Python 3 is failing in the terminal section - should be completely unrelated. Can you trigger it to run again? |
|
It still looks a bit off at least for the sliders. FF on the R: The space between the handles is different, but the height of the slider track is also different. What about the following. Let's create a "super widget" that is a container with all the different types of widgets inside of it in different arrangements, with/wo descriptions, etc. We can then use that to do a more complete visual audit of the styles and compare C + FF. |
Just tried, looks like you already did? |
|
I've prodded it to restart. @ellisonbg , any of us should be able to restart Travis jobs on the ipython repo. However, a failure in terminal is manifestly not relevant - let's not get into the habit of always waiting for a green indicator from Travis. |
|
Presenting lé super widget |
|
If you are showcasing.... completions with default values. |
Very cool! |
|
This PR is now rebased on top of #5075 - so don't think about merging this until that gets merged! |
|
After tweaking some more, and merging the latest from the new fbox model PR... The text area is a different height for the same number of lines (something different about how FF calculates it from the font size). I don't think that I can fix that. Correcting the text area height in my image editor lets us compare the rest of the elements... |
|
Note: There are much much more side by side comparisons generated by the super widget. I will continue to look at them more. |
|
This should be ready to merge when the tests are done, do you want to look at this again @ellisonbg - I just looked at FF25 and Chrome31 and the widgets all align correctly. Here is the "superwidget" -> https://gist.github.com/jdfreder/9103330 |
|
Tests are failing on this one. After lunch I will start to work on code review... |
|
Whoops, looks like there was a small typo |
|
It passes now |
|
Great! I have tested this on FF and Chrome and all looks great. Merging. |
FF Fix: alignment and scale of text widget
|
Thanks! |
FF Fix: alignment and scale of text widget
4 participants
Fixes #5013