Skip to content

Updates to shell reference doc#5330

Merged
takluyver merged 3 commits into
ipython:masterfrom
takluyver:interactive-reference-updates
Mar 25, 2014
Merged

Updates to shell reference doc#5330
takluyver merged 3 commits into
ipython:masterfrom
takluyver:interactive-reference-updates

Conversation

@takluyver
Copy link
Copy Markdown
Member

This is quite a long document, and various bits of it haven't been updated in quite a while. I cleaned up most of the obvious flaws.

@damianavila
Copy link
Copy Markdown
Member

LGTM

Comment thread docs/source/interactive/reference.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either 'Hit Ctrl-r to open' or 'Ctrl-r opens' or 'Hitting Ctrl-r opens'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ellisonbg
Copy link
Copy Markdown
Member

This looks good I am +1 on merging.

@takluyver
Copy link
Copy Markdown
Member Author

@ellisonbg I touched a couple of examples (which are literalinclude-d in this doc), so this may conflict with your examples reorg. Are you OK with that, or would you like me to wait and rebase after that's merged?

@ellisonbg
Copy link
Copy Markdown
Member

If you don't mind, let's wait until mine is merged for those changes.
Thanks.

On Thu, Mar 13, 2014 at 2:22 PM, Thomas Kluyver notifications@github.comwrote:

@ellisonbg https://github.com/ellisonbg I touched a couple of examples
(which are literalinclude-d in this doc), so this may conflict with your
examples reorg. Are you OK with that, or would you like me to wait and
rebase after that's merged?

Reply to this email directly or view it on GitHubhttps://github.com//pull/5330#issuecomment-37588453
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@ivanov ivanov added this to the 2.0 milestone Mar 20, 2014
@takluyver
Copy link
Copy Markdown
Member Author

@ellisonbg , we said at the dev meeting that we wouldn't hold the release for your PR #5337. However, this is a smaller change, and I'd like to get it in before the 2.0 docs are built. Can we merge this one and give you a (fairly simple) rebase to do in #5337?

@ellisonbg
Copy link
Copy Markdown
Member

+1

Sent from my iPhone

On Mar 24, 2014, at 12:55 PM, Thomas Kluyver notifications@github.com wrote:

@ellisonbg , we said at the dev meeting that we wouldn't hold the release for your PR #5337. However, this is a smaller change, and I'd like to get it in before the 2.0 docs are built. Can we merge this one and give you a (fairly simple) rebase to do in #5337?


Reply to this email directly or view it on GitHub.

takluyver added a commit that referenced this pull request Mar 25, 2014
@takluyver takluyver merged commit ece49eb into ipython:master Mar 25, 2014
@takluyver
Copy link
Copy Markdown
Member Author

Thanks.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants