Skip to content

Fix Gecko (Netscape) keyboard handling#5391

Merged
ellisonbg merged 1 commit into
ipython:masterfrom
jdfreder:netscape-keyboard
Mar 20, 2014
Merged

Fix Gecko (Netscape) keyboard handling#5391
ellisonbg merged 1 commit into
ipython:masterfrom
jdfreder:netscape-keyboard

Conversation

@jdfreder
Copy link
Copy Markdown
Contributor

It took a while for me to track down this bug which was uncovered by the SlimerJS tests. 😀

Our browser detection appropriately sees SlimerJS as Netscape, which is the original source of the Gecko rendering engine.

@damianavila
Copy link
Copy Markdown
Member

👍

@ellisonbg
Copy link
Copy Markdown
Member

Looks good, merging.

ellisonbg added a commit that referenced this pull request Mar 20, 2014
Fix Gecko (Netscape) keyboard handling
@ellisonbg ellisonbg merged commit ebfe1ae into ipython:master Mar 20, 2014
@jdfreder jdfreder deleted the netscape-keyboard branch March 26, 2014 17:25
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Fix Gecko (Netscape) keyboard handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants