fix n^2 performance issue in coalesce_streams preprocessor#5535
Merged
Conversation
Member
Author
|
Also fix some logging, so this can be more easily debugged in the future, and various typos, etc. found in nearby docstrings. |
Member
Author
|
This bug is bad enough that I think it's actually what is responsible for bringing down nbviewer recently. |
for n consecutive stream outputs, `\r` fix would be compiled n times, and applied to each output (n-i) times. - move pattern to module level - apply replacement after coalescing outputs
also cleanup spelling and grammar in a few docstrings
Member
There was a problem hiding this comment.
How about just making output_type not be a keyword argument/have a default argument of None?
Member
|
At least for nbviewer, it seems like we would find this better if we were tracking render/load times more aggressively. Right now it all appears in the logs, but we're not tracking performance of the same notebooks over time. |
and fix bug that this would have revealed
ivanov
added a commit
that referenced
this pull request
Apr 8, 2014
fix n^2 performance issue in coalesce_streams preprocessor
minrk
added a commit
that referenced
this pull request
Apr 9, 2014
…rocessor for n consecutive stream outputs, `\r` fix would be compiled n times, and applied to each ith output (n-i) times. - move pattern to module level - apply replacement after coalescing outputs An example notebook from nbviewer with ~1k outputs that was taking 90 seconds to render now takes 3 seconds.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix n^2 performance issue in coalesce_streams preprocessor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for n consecutive stream outputs,
\rfix would be compiled n times, and applied to each ith output (n-i) times.An example notebook from nbviewer with ~1k outputs that was taking 90 seconds to render now takes 3 seconds.