feat: extend Wallet with on-chain signing (unblocks Track 2)#2
Merged
Conversation
The Wallet interface only had signMessage (session encryption). On-chain work (skill NFT mint, notes) needs Solana tx signing, so Wallet now extends iqlabs-sdk's WalletSigner (publicKey + signTransaction + signAllTransactions) — the same shape Phantom exposes, so any front-end (Phantom/Ledger/local key/mobile) can satisfy it. - contract.ts: Wallet extends WalletSigner - account/keypairWallet.ts: keypairWallet(kp) builds a full Wallet from a Keypair (real tx signing); testWallet(seed) for tests/CLI/non-interactive signers - scripts + vscode extension: use testWallet() instead of inline fake wallets Track 2 (on-chain) can now start against testWallet on devnet without a real wallet. Real Phantom UI stays a Track 1 task. Tested: pnpm test:run PASS, vscode build OK.
This was referenced Jun 14, 2026
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet only had signMessage (session encryption). On-chain work needs Solana tx signing, so Wallet now extends iqlabs-sdk WalletSigner (publicKey + signTransaction + signAllTransactions) — same shape Phantom exposes, so any front-end can satisfy it via an adapter.
Track 2 can now start against testWallet on devnet without a real wallet. Real Phantom UI stays a Track 1 task.
Tested: pnpm test:run PASS, vscode build OK.