RSDEV-950: Add OtherReferences field when building into Dataset#34
Conversation
cb4f175 to
912a064
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the otherReferences field to the Dataset entity, allowing multiple reference URLs to be associated with a dataset. The PR also includes unrelated build configuration changes to support Maven publishing.
Changes:
- Added
otherReferencesfield toDatasetFacadewith Lombok's@Singularannotation for builder support - Implemented
addOtherReferences()method inDatasetBuilderto populate the field when building Dataset objects - Added test data using the new
otherReference()builder method in test factory methods - Configured maven-publish plugin in build.gradle for publishing to GitHub packages
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/researchspace/dataverse/entities/facade/DatasetFacade.java | Added otherReferences field with @Singular annotation and reorganized imports to use individual lombok imports |
| src/main/java/com/researchspace/dataverse/entities/facade/DatasetBuilder.java | Added OTHER_REFERENCES constant, implemented addOtherReferences() method, and reorganized imports |
| src/test/java/com/researchspace/dataverse/entities/facade/DatasetTestFactory.java | Added otherReference test data to both test factory methods |
| build.gradle | Added maven-publish plugin configuration for publishing artifacts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0a725c0 to
37d93c1
Compare
mKowalski256
left a comment
There was a problem hiding this comment.
Not sure about method in DatasetBuilder, which is named as if it was setting multiple references, but only sets first found one.
Also, could you update the Changelog file?
37d93c1 to
1d09a78
Compare
There was a problem hiding this comment.
Looks good, can you also update the changelog file when bumping the version?
1d09a78 to
3d4f007
Compare
3d4f007 to
7d0e875
Compare
7d0e875 to
0b724e2
Compare
No description provided.