Skip to content

RSDEV-950: Add OtherReferences field when building into Dataset#34

Merged
mKowalski256 merged 1 commit intoIQSS:mainfrom
rspace-os:RSDEV-950-dataverse-client
Feb 25, 2026
Merged

RSDEV-950: Add OtherReferences field when building into Dataset#34
mKowalski256 merged 1 commit intoIQSS:mainfrom
rspace-os:RSDEV-950-dataverse-client

Conversation

@rs-nicof
Copy link
Copy Markdown
Contributor

No description provided.

@rs-nicof rs-nicof force-pushed the RSDEV-950-dataverse-client branch 3 times, most recently from cb4f175 to 912a064 Compare February 24, 2026 14:38
@mKowalski256 mKowalski256 assigned rs-nicof and unassigned rs-nicof Feb 24, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for the otherReferences field to the Dataset entity, allowing multiple reference URLs to be associated with a dataset. The PR also includes unrelated build configuration changes to support Maven publishing.

Changes:

  • Added otherReferences field to DatasetFacade with Lombok's @Singular annotation for builder support
  • Implemented addOtherReferences() method in DatasetBuilder to populate the field when building Dataset objects
  • Added test data using the new otherReference() builder method in test factory methods
  • Configured maven-publish plugin in build.gradle for publishing to GitHub packages

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/main/java/com/researchspace/dataverse/entities/facade/DatasetFacade.java Added otherReferences field with @Singular annotation and reorganized imports to use individual lombok imports
src/main/java/com/researchspace/dataverse/entities/facade/DatasetBuilder.java Added OTHER_REFERENCES constant, implemented addOtherReferences() method, and reorganized imports
src/test/java/com/researchspace/dataverse/entities/facade/DatasetTestFactory.java Added otherReference test data to both test factory methods
build.gradle Added maven-publish plugin configuration for publishing artifacts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/java/com/researchspace/dataverse/entities/facade/DatasetBuilder.java Outdated
Copy link
Copy Markdown
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about method in DatasetBuilder, which is named as if it was setting multiple references, but only sets first found one.

Also, could you update the Changelog file?

@rs-nicof rs-nicof force-pushed the RSDEV-950-dataverse-client branch from 37d93c1 to 1d09a78 Compare February 25, 2026 11:31
Copy link
Copy Markdown
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also update the changelog file when bumping the version?

@rs-nicof rs-nicof force-pushed the RSDEV-950-dataverse-client branch from 1d09a78 to 3d4f007 Compare February 25, 2026 11:59
Comment thread build.gradle Outdated
@rs-nicof rs-nicof force-pushed the RSDEV-950-dataverse-client branch from 3d4f007 to 7d0e875 Compare February 25, 2026 12:18
@rs-nicof rs-nicof force-pushed the RSDEV-950-dataverse-client branch from 7d0e875 to 0b724e2 Compare February 25, 2026 12:21
@mKowalski256 mKowalski256 merged commit 9d30cef into IQSS:main Feb 25, 2026
@mKowalski256 mKowalski256 deleted the RSDEV-950-dataverse-client branch February 25, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants