Skip to content

Conversation

@g-saracca
Copy link
Contributor

What this PR does / why we need it:

This just adds a new SCORE option to the SortType enum

Which issue(s) this PR closes:

Suggestions on how to test this:

Code review and tests passing.

@github-actions github-actions bot added GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature labels May 29, 2025
@g-saracca g-saracca changed the title feat: add enum option SCORE option in SortType enum May 29, 2025
@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project May 29, 2025
@ekraffmiller ekraffmiller self-assigned this May 29, 2025
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project May 29, 2025
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need a validation test in the getCollectionItems use case that checks if searchText is defined, when order is set to SCORE?

@cmbz cmbz added the FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) label May 29, 2025
@g-saracca
Copy link
Contributor Author

Looks good. Do we need a validation test in the getCollectionItems use case that checks if searchText is defined, when order is set to SCORE?

Not sure I would do that, the API is not complaining about that, if you send q=* you can send sort=score.

@g-saracca
Copy link
Contributor Author

@ekraffmiller this is the SPA side PR using this PR version in case you want to review it also.

@ekraffmiller
Copy link
Contributor

Looks good. Do we need a validation test in the getCollectionItems use case that checks if searchText is defined, when order is set to SCORE?

Not sure I would do that, the API is not complaining about that, if you send q=* you can send sort=score.
Ok, sounds good. I saw that too, I just wanted to check what you think.

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project May 29, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 29, 2025
@ofahimIQSS ofahimIQSS self-assigned this May 29, 2025
@ofahimIQSS
Copy link
Contributor

Tests are passing - merging PR

@ofahimIQSS ofahimIQSS merged commit 684c2cd into develop May 29, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project May 29, 2025
@ofahimIQSS ofahimIQSS deleted the 309-score-sort-type branch May 29, 2025 15:36
@ofahimIQSS ofahimIQSS removed their assignment May 29, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Add SCORE SortType

5 participants