-
Notifications
You must be signed in to change notification settings - Fork 10
SCORE option in SortType enum #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ekraffmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do we need a validation test in the getCollectionItems use case that checks if searchText is defined, when order is set to SCORE?
Not sure I would do that, the API is not complaining about that, if you send |
|
@ekraffmiller this is the SPA side PR using this PR version in case you want to review it also. |
|
ekraffmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved
|
Tests are passing - merging PR |
What this PR does / why we need it:
This just adds a new
SCOREoption to theSortTypeenumWhich issue(s) this PR closes:
Suggestions on how to test this:
Code review and tests passing.