Skip to content

Conversation

@ChengShi-1
Copy link
Contributor

@ChengShi-1 ChengShi-1 commented May 29, 2025

What this PR does / why we need it:

http://localhost:8000/api/v1/files/4/dataTables leads an error {"status":"ERROR","message":"Insufficient permissions to access the requested information."} This error affected the file page and dataset page, preventing the file info to be displayed
image

The correct way is, even the file is restricted, basic file info in dataset file lists should be shown, and file page should be shown without error.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Two users: user A and user B (you could also log in A in JSF and B in SPA, same behavior below)

  1. A creates a dataset, and uploads a .tab format file
  2. A should also set this file to be restricted, then publish dataset
  3. log out A, log in B
  4. B should be able to see some details but cannot download because the file is restricted.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions bot added bug Something isn't working FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) GREI Re-arch GREI re-architecture-related SPA.Q2 Not related to any specific Q2 feature labels May 29, 2025
@ChengShi-1 ChengShi-1 added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels May 29, 2025
@ChengShi-1 ChengShi-1 changed the title fix: restricted files should be shown in the list File: restricted file(in .tab format) should be shown even it's restricted May 29, 2025
@coveralls
Copy link

coveralls commented May 29, 2025

Coverage Status

coverage: 97.403% (-0.009%) from 97.412%
when pulling 0998e6a on 711-dataset-page-and-file-page-restricted-filetab-format-cannot-be-accessed
into 8638764 on develop.

@ChengShi-1 ChengShi-1 marked this pull request as ready for review May 29, 2025 21:51
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project May 29, 2025
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 4, 2025
@g-saracca g-saracca self-assigned this Jun 4, 2025
@cmbz cmbz added the FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) label Jun 4, 2025
g-saracca
g-saracca previously approved these changes Jun 5, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround, works good also

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 5, 2025
@g-saracca
Copy link
Contributor

@ChengShi-1 I've approved this already, but please solve merge conflicts and I will approve again 👍🏼 , thanks!

@g-saracca g-saracca moved this from Ready for QA ⏩ to In Review 🔎 in IQSS Dataverse Project Jun 5, 2025
@g-saracca g-saracca removed their assignment Jun 5, 2025
@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Jun 5, 2025
@ofahimIQSS ofahimIQSS self-assigned this Jun 5, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jun 5, 2025
@ofahimIQSS
Copy link
Contributor

Fix looks good to me - merging

image

@ofahimIQSS ofahimIQSS merged commit 08188b1 into develop Jun 5, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jun 5, 2025
@ofahimIQSS ofahimIQSS deleted the 711-dataset-page-and-file-page-restricted-filetab-format-cannot-be-accessed branch June 5, 2025 15:40
@ofahimIQSS ofahimIQSS removed their assignment Jun 5, 2025
@ChengShi-1
Copy link
Contributor Author

ChengShi-1 commented Jun 5, 2025

@ofahimIQSS Hi Omer, the screenshot here is from JSF, could you see if it's the same on SPA again? Thanks!

@ofahimIQSS
Copy link
Contributor

@ofahimIQSS Hi Omer, the screenshot here is from JSF, could you see if it's the same on SPA again? Thanks!

woops, added the wrong screenshot, here is the SPA:
image

@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Jun 16, 2025
@cmbz cmbz added the FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working FY25 Sprint 24 FY25 Sprint 24 (2025-05-21 - 2025-06-04) FY25 Sprint 25 FY25 Sprint 25 (2025-06-04 - 2025-06-18) FY26 Sprint 4 FY26 Sprint 4 (2025-08-13 - 2025-08-27) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page SPA.Q2 Not related to any specific Q2 feature

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Dataset Page and File Page: restricted file(.tab format) cannot be accessed

6 participants