Show terms modal before download when dataset has custom terms or non-default license

[ChengShi-1]

What this PR does / why we need it:

When downloading file/files/dataset for a dataset with custom terms, a popup window should be shown

Which issue(s) this PR closes:

• Closes Dataset Terms Modal should be showed when download files with custom terms #938

Special notes for your reviewer:

Suggestions on how to test this:

• create a dataset and upload a file
• set dataset terms to CC BY 4.0

- publish the dataset and log out as a guest user - download a file, then you should see a modal with the terms - log in and set dataset terms to custom terms, the modal should also be shown - the modal is only shown to guest user or other user who doesn't have edit permission, and the dataset should be non-draft version ## Does this PR introduce a user interface change? If mockups are available, please link/include them here: For custom terms:

Is there a release notes or changelog update needed for this change?:

yes

Additional documentation:

[Copilot]

Pull request overview

This PR expands the “download guard” behavior so that users must accept dataset terms before starting a download when a dataset has custom terms, a non-default license (not CC0 1.0), or a guestbook—while continuing to bypass the modal for draft datasets and dataset editors.

Changes:

• Generalized the download gating condition from “guestbook exists” to “terms/custom license/guestbook requires acceptance” across dataset, file, and bulk-download entry points.
• Renamed/extended the modal component to DownloadWithTermsAndGuestbookModal and adjusted the form/hook logic to support “custom terms only” scenarios.
• Added/updated component + e2e tests and updated the changelog.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/e2e-integration/shared/datasets/DatasetHelper.ts	Adds helper to set dataset custom terms via API for e2e setup.
tests/e2e-integration/e2e/sections/file/File.spec.tsx	Adds e2e coverage for file downloads triggering terms modal for guests but not editors.
tests/e2e-integration/e2e/sections/dataset/Dataset.spec.tsx	Adds e2e coverage for dataset ZIP downloads triggering terms modal for guests but not editors; refactors /spa base path.
tests/component/sections/file/file-action-buttons/access-file-menu/FileTabularDownloadOptions.spec.tsx	Updates props to match new “requires terms/guestbook” gating.
tests/component/sections/file/file-action-buttons/access-file-menu/FileNonTabularDownloadOptions.spec.tsx	Updates props to match new “requires terms/guestbook” gating.
tests/component/sections/file/file-action-buttons/access-file-menu/AccessFileMenu.spec.tsx	Adds component coverage for terms-only modal and bypass behavior (draft/editor).
tests/component/sections/dataset/dataset-files/guestbook/DownloadWithTermsAndGuestbookModal.spec.tsx	Renames and extends modal tests to cover “custom terms only” behavior.
tests/component/sections/dataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.spec.tsx	Adds bulk-download tests ensuring modal appears for custom terms and bypasses for editors.
tests/component/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.spec.tsx	Adds dataset menu tests for custom terms and non-default license triggering modal + bypass cases.
src/stories/guestbooks/guestbook-applied-modal/DownloadWithTermsAndGuestbookModal.stories.tsx	Updates story to new modal component name and storybook metadata.
src/sections/file/file-action-buttons/access-file-menu/FileTabularDownloadOptions.tsx	Renames prop to requiresTermsOrGuestbook and uses it to decide modal vs direct download.
src/sections/file/file-action-buttons/access-file-menu/FileNonTabularDownloadOptions.tsx	Renames prop to requiresTermsOrGuestbook and uses it to decide modal vs direct download.
src/sections/file/file-action-buttons/access-file-menu/FileDownloadOptions.tsx	Implements new gating logic (custom terms/non-default license/guestbook) for file downloads and swaps modal component.
src/sections/dataset/dataset-files/files-table/file-actions/file-actions-cell/file-action-buttons/file-options-menu/useGuestbookCollectSubmission.ts	Simplifies submission handler to support modal flows without a loaded guestbook object.
src/sections/dataset/dataset-files/files-table/file-actions/file-actions-cell/file-action-buttons/file-options-menu/GuestbookCollectForm.tsx	Hides guestbook fields when no guestbook is present; updates stylesheet import.
src/sections/dataset/dataset-files/files-table/file-actions/file-actions-cell/file-action-buttons/file-options-menu/DownloadWithTermsAndGuestbookModal.tsx	Renames modal component and enables operation when no guestbook exists (terms/license-only).
src/sections/dataset/dataset-files/files-table/file-actions/file-actions-cell/file-action-buttons/file-options-menu/DownloadWithTermsAndGuestbookModal.module.scss	Adds styling module used by the updated terms/guestbook UI.
src/sections/dataset/dataset-files/files-table/file-actions/download-files/DownloadFilesButton.tsx	Extends bulk-download flow to show modal for custom terms/non-default license; passes license/terms into modal.
src/sections/dataset/dataset-action-buttons/access-dataset-menu/AccessDatasetMenu.tsx	Extends dataset ZIP download flow to show modal for custom terms/non-default license; passes license/terms into modal.
CHANGELOG.md	Documents the expanded conditions that trigger the terms modal and bypass rules.

Comments suppressed due to low confidence (1)

src/sections/dataset/dataset-files/files-table/file-actions/file-actions-cell/file-action-buttons/file-options-menu/DownloadWithTermsAndGuestbookModal.tsx:60

• With this PR the modal can open even when guestbookId is undefined (custom terms / non-default license only). In that case the form fields are hidden, but prefilledAccountFieldValues still populates formValues for authenticated users and buildGuestbookResponse() will submit name/email/etc on Accept. This can unintentionally send PII to the access API when no guestbook is configured. Consider clearing/avoiding identity field prefills and submitting an empty guestbook response when hasGuestbook is false.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coveralls]

coverage: 97.577% (+0.01%) from 97.564% — 938-dataset-terms-modal-should-be-showed-when-download-files-with-custom-terms into develop