fix for Container dev_solr invalid start port '8983:8983': invalid syntax#978
Merged
fix for Container dev_solr invalid start port '8983:8983': invalid syntax#978
Conversation
…ntax This PR had a defect in it: - #928 Now commands like this should work fine, which was the original intent: curl http://localhost:8983/solr/collection1/schema/fields See doc/sphinx-guides/source/container/running/demo.rst under "Additional Metadata Blocks" for related commands.
|
coverage: 97.515% (-0.05%) from 97.565% — 928-expose-solr-port into develop |
jp-tosca
approved these changes
Apr 30, 2026
github-project-automation
Bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR had a defect in it (sorry):
Now commands like this should work fine, which was the original intent:
See doc/sphinx-guides/source/container/running/demo.rst under "Additional Metadata Blocks" for related commands. Here: https://guides.dataverse.org/en/6.10.1/container/running/demo.html#additional-metadata-blocks
This change should make the "update Solr" steps in the following PR (where we add the "review" block) actually work: