EditDDI API empty frequency bug#11378
Merged
ofahimIQSS merged 5 commits intoIQSS:developfrom Apr 22, 2025
Merged
Conversation
qqmyers
reviewed
Mar 28, 2025
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
Author
|
I updated the branch from IQSS develop, no other changes. But there seems to be a problem with the test RemoteOverlayAccessIOTest.testRemoteOverlayFiles The problem is with https://data.qdr.syr.edu/resources/images/dataverse_progect_logo.svg Replacing https://data.qdr.syr.edu/resources with https://demo.dataverse.org/resources seems to solve the problem. The change was made here 3674a6f |
Contributor
|
looks like continuous integration is failing still |
Contributor
Author
|
@ofahimIQSS Which test is failing? Is it me or does it fail for everyone? |
Member
|
There was a problem in the develop branch - fixed today - if you merge with the latest the test should pass. |
Contributor
|
looks good, merging |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In EditDDI api when frequency is declared in input xml file but missing the api returns 200 code, but this breaks DDI exporter since frequency is declared but missing (null).
For that case in this PR EditDDI api returns 400 code of bad request of bad xml file. Integration test for that case was updated.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Upload spss or STATA file with categories. Download Variable Metadata xml for that file. Edit xml by removing frequency number (empty frequency). Use
curl -H "X-Dataverse-key:$API_TOKEN" -X PUT "$SERVER_URL/api/edit/$ID" --upload-file $FILEto update the var metedata, where $ID is file id and $File is updated xml. One should get 400 error.