Skip to content

Hide Version Notes column on version tab of the dataset page when Version Notes have not been enabled#11396

Merged
ofahimIQSS merged 1 commit intodevelopfrom
11395-version-tab-rendering
Apr 7, 2025
Merged

Hide Version Notes column on version tab of the dataset page when Version Notes have not been enabled#11396
ofahimIQSS merged 1 commit intodevelopfrom
11395-version-tab-rendering

Conversation

@sekmiller
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Hides Version Notes column on version tab of the dataset page when Version Notes have not been enabled.

Not a killer bug but putting it in as a patch on 6.6 might prevent some questions from users.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions Bot added the Type: Bug a defect label Apr 3, 2025
@sekmiller sekmiller moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 3, 2025
Copy link
Copy Markdown
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but it seems like a reasonable fix.

@github-project-automation github-project-automation Bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Apr 3, 2025
@sekmiller sekmiller added the Size: 0.5 A percentage of a sprint. 0.35 hours label Apr 3, 2025
@cmbz cmbz added the FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) label Apr 7, 2025
@ofahimIQSS ofahimIQSS self-assigned this Apr 7, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 7, 2025
@ofahimIQSS
Copy link
Copy Markdown
Contributor

Looks good to me @sekmiller , tested the PR with as version note flag set to true and false. As expected, when version notes flag is set to false, the version note column no longer appears on the UI.

image

@ofahimIQSS ofahimIQSS merged commit f5a1a5f into develop Apr 7, 2025
8 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 7, 2025
@ofahimIQSS ofahimIQSS deleted the 11395-version-tab-rendering branch April 7, 2025 17:22
@ofahimIQSS ofahimIQSS removed their assignment Apr 7, 2025
@pdurbin pdurbin added this to the 6.7 milestone Apr 7, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 8, 2025
@pdurbin pdurbin changed the title #11395 fix render Hide Version Notes column on version tab of the dataset page when Version Notes have not been enabled Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Version Notes tab visible when version notes are not enabled

5 participants