Memory Improvements in Export/Ingest#11417
Merged
ofahimIQSS merged 4 commits intoIQSS:developfrom Apr 22, 2025
Merged
Conversation
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
landreev
approved these changes
Apr 21, 2025
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
(out of scope of the pr, but this reminds me that we need to retire UNF. I don't think it costs us all that much, performance-wise, since we are subsetting the entire datafile into variable vectors to calculate sum. stats anyway. but it's not clear if it adds any value at this point either). |
Contributor
|
Hello, can I get an update with latest from dev for this. |
Contributor
|
looks good from my end, tested as described and performed further regression testing of other export metadata. merging. |
github-project-automation
Bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: I scanned through the exporters and parts of ingest with AI and tried to address anything indicated as a potential memory/resource leak or where potentially large amounts of info were being loaded into memory.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Verify that export results, particularly the DDI export are the same for tabular files, both local files and S3 storage.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: