Skip to content

Fix license acceptance pop-up for Archival Format download. #12412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janvanmansum wants to merge 2 commits into
base: develop
Choose a base branch
from
+2 −0
Open

Fix license acceptance pop-up for Archival Format download. #12412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08fa6da
When downloading a dataset with:
janvanmansum May 29, 2026
65ab7f0
release note
janvanmansum May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/release-notes/12412-fixed-license-acceptance-popup-for-archival-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed an issue where, in some cases, the license acceptance pop-up for the archival format option did not display correctly when downloading a complete dataset.
1 change: 1 addition & 0 deletions src/main/webapp/dataset.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@
<h:outputFormat value="#{bundle['dataset.accessBtn.download.size']}">
<f:param value="#{sizeOfDataset}" />
</h:outputFormat>
<f:actionListener binding="#{DatasetPage.setTermsGuestbookPopupAction(bundle.download)}"/>
</p:commandLink>
</li>
<!-- Archival Format too big -->
Expand Down