500 internal server error when starting a testcase through the REST API with malformed JSON

[olw-medcom]

Hey there!

It seems that when I attempt to call POST https://test.itb.medcom.dk/api/rest/tests/start with some malformed JSON:

{
    "system": "bla",
    "testCase": [
        "ekg-document-validation-only"
    missing end-bracket here,
    "testSuite": ["EKG-document-creator-suite"],
    "actor": "bla",
    "inputMapping": [
        {
            "input": {
                "name": "isAPITestExecution",
                "value": "true"
            }
        }
    ]
}

Then I get a 500 Internal Server Error response with this body:

{
    "error_code": "Unexpected error",
    "error_description": "Invalid Json: Unexpected character ('m' (code 109)): was expecting comma to separate Array entries\n at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 5, column: 5].",
    "error_id": ""
}

This is quite misinforming and I've had a vendor that thought it was an error on the ITB side rather than their own JSON code. I was wondering if atleast the error could become a 400 bad request instead?

[costas80]

Hi @olw-medcom.

Excellent point. We had also noted that the REST API should return 400 errors for bad input as opposed to 500 (which would suggest an internal error). We will also adapt the returned error description/code to make it clear that this relates to a client issue.

We'll add this to the TODO list and will let you know when it's ready to pull.

[costas80]

The update is ready to pull from the nightly build @olw-medcom.

Can you confirm the fix when you get round to trying this out? Thanks!