Ticket1843: Nanodac Support#124
Merged
mattclarke merged 13 commits intomasterfrom Mar 21, 2017
Merged
Conversation
…omputingGroup/EPICS-ioc into Ticket1843_nanodac_support Conflicts: Makefile
Contributor
Author
|
Have fixed the issues highlighted via slack |
Contributor
Author
|
Fixed the follwoing issues highlighted on Slack:
Note that some of these changes are in the support module, you will need the latest master from that repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Added the nanodac IOC.
To test
You will also need https://github.com/ISISComputingGroup/EPICS-nanodac
Fixes ISISComputingGroup/IBEX#1843
Add the nanodac as part of a configuration. It is currently on 130.246.49.95.
Check that you can read all four channels on %MYPVPREFIX%NANODAC:CH1:PV etc. PVs should be around room temperature.
Code Review
check_opi_format.pyto help with this.Functional Tests
Final steps