Skip to content

Ticket1843: Nanodac Support#124

Merged
mattclarke merged 13 commits intomasterfrom
Ticket1843_nanodac_support
Mar 21, 2017
Merged

Ticket1843: Nanodac Support#124
mattclarke merged 13 commits intomasterfrom
Ticket1843_nanodac_support

Conversation

@DominicOram
Copy link
Copy Markdown
Contributor

@DominicOram DominicOram commented Mar 2, 2017

Description of work

Added the nanodac IOC.

To test

You will also need https://github.com/ISISComputingGroup/EPICS-nanodac

Fixes ISISComputingGroup/IBEX#1843

Add the nanodac as part of a configuration. It is currently on 130.246.49.95.
Check that you can read all four channels on %MYPVPREFIX%NANODAC:CH1:PV etc. PVs should be around room temperature.


Code Review

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • Does the IOC respond correctly both in full and simulation mode, where it's possible to test both?
  • If there are multiple _0n IOCs, do they run correctly?

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@DominicOram
Copy link
Copy Markdown
Contributor Author

Have fixed the issues highlighted via slack

@DominicOram
Copy link
Copy Markdown
Contributor Author

Fixed the follwoing issues highlighted on Slack:

  • Changed name to NANODAC-IOC-01
  • Added SIM/DISABLE
  • Changed PV names to be more understandable (so now look at %MYPVPREFIX%NANODAC_01:CH1:TEMP)

Note that some of these changes are in the support module, you will need the latest master from that repo.

@mattclarke mattclarke merged commit cf622eb into master Mar 21, 2017
@mattclarke mattclarke deleted the Ticket1843_nanodac_support branch March 21, 2017 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants