Add support for sending unsolicited messages from a device #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used in the gamry device. It sends a "charge complete"
message some seconds after being sent a command to "start charging".
This is accomplished by code similar to the following
in the device StreamInterface:
def charged(self):
self.handler.unsolicitedReply("STOPPED")
def start_charging(self):
t = Timer(self.charging_time, self.charged)
t.start()
return "STARTED"
Contributor
|
@mattclarke, would you like to take a look at this? Otherwise I'm happy to merge it. |
mattclarke
approved these changes
May 4, 2020
Contributor
mattclarke
left a comment
mattclarke
left a comment
There was a problem hiding this comment.
Other than the suggested renaming, it looks good to me
Co-authored-by: Matt Clarke <matt.clarke@ess.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used, for example, in the simulated gamry device. It sends a "charge complete"
unsolicited message some seconds after being sent a command to "start charging".
The PR adds a unsolicited_reply() method so code like the following in the device
StreamInterface can accomplish this: