Skip to content

uktena: Update snmp packages#30

Draft
FreddieAkeroyd wants to merge 1 commit into
mainfrom
update_snmp
Draft

uktena: Update snmp packages#30
FreddieAkeroyd wants to merge 1 commit into
mainfrom
update_snmp

Conversation

@FreddieAkeroyd
Copy link
Copy Markdown
Member

No description provided.

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks May 7, 2026
@FreddieAkeroyd FreddieAkeroyd changed the title Update snmp packages uktena: Update snmp packages May 7, 2026
@Tom-Willemsen Tom-Willemsen self-requested a review May 13, 2026 12:54
Copy link
Copy Markdown
Member

@Tom-Willemsen Tom-Willemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to break dbsvr:

[2026-05-13 14:15:39.884486] INFO: inserting moxa mappings to SQL
[2026-05-13 14:15:39.889444] INFO: moxa name: unknown - IP: 130.246.53.169
[2026-05-13 14:15:39.891990] INFO: moxa name: unknown, phys port: 1, com_port: 5
[2026-05-13 14:15:39.894054] INFO: moxa name: unknown, phys port: 2, com_port: 6
[2026-05-13 14:15:39.895799] INFO: moxa name: unknown, phys port: 3, com_port: 7
[2026-05-13 14:15:39.898118] INFO: moxa name: unknown, phys port: 4, com_port: 8
[2026-05-13 14:15:39.900221] INFO: moxa name: unknown, phys port: 5, com_port: 9
[2026-05-13 14:15:39.901952] INFO: moxa name: unknown, phys port: 6, com_port: 10
[2026-05-13 14:15:39.903771] INFO: moxa name: unknown, phys port: 7, com_port: 11
[2026-05-13 14:15:39.906003] INFO: moxa name: unknown, phys port: 8, com_port: 12
[2026-05-13 14:15:39.907832] INFO: moxa name: unknown, phys port: 9, com_port: 13
[2026-05-13 14:15:39.909591] INFO: moxa name: unknown, phys port: 10, com_port: 14
[2026-05-13 14:15:39.911314] INFO: moxa name: unknown, phys port: 11, com_port: 15
[2026-05-13 14:15:39.913184] INFO: moxa name: unknown, phys port: 12, com_port: 16
[2026-05-13 14:15:39.915026] INFO: moxa name: unknown, phys port: 13, com_port: 17
[2026-05-13 14:15:39.917259] INFO: moxa name: unknown, phys port: 14, com_port: 18
[2026-05-13 14:15:39.919231] INFO: moxa name: unknown, phys port: 15, com_port: 19
[2026-05-13 14:15:39.921335] INFO: moxa name: unknown, phys port: 16, com_port: 20
Exception in thread [2026-05-13 14:15:39.923137] INFO: Connected to moxa details database
Thread-1 (_update_snmp):
Traceback (most recent call last):
  File "C:\Instrument\Apps\Python3\Lib\threading.py", line 1043, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "C:\Instrument\Apps\Python3\Lib\threading.py", line 994, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Instrument\Apps\EPICS\ISIS\inst_servers\master\DatabaseServer\moxa_data.py", line 182, in _update_snmp
    mibmap = walk(ip_addr, "1.3.6.1.2.1", SYSTEM_MIBS + PORT_MIBS)
  File "C:\Instrument\Apps\Python3\Lib\site-packages\server_common\snmpWalker.py", line 30, in walk
    for errorIndication, errorStatus, errorIndex, varBinds in nextCmd(
                                                              ^^^^^^^
NameError: name 'nextCmd' is not defined

Chsudeepta
Chsudeepta previously approved these changes May 13, 2026
@Chsudeepta Chsudeepta dismissed their stale review May 13, 2026 13:27

Didn't see Tom's comment

@FreddieAkeroyd
Copy link
Copy Markdown
Member Author

Hmm ... I have moxas defined and didn't see any errors, but it seems to be ignoring my moxas that are in nport which probably explains the lack of errors ...

[Wed May 13 16:32:31 2026] [2026-05-13 16:32:31.298553] INFO: Connected to IOCData database
[Wed May 13 16:32:33 2026] [2026-05-13 16:32:33.261261] INFO: Connected to experimental details database
[Wed May 13 16:32:35 2026] [2026-05-13 16:32:35.181736] INFO: updating moxa mappings
[Wed May 13 16:32:35 2026] [2026-05-13 16:32:35.181859] MINOR: using old style registry for moxas
[Wed May 13 16:32:35 2026] [2026-05-13 16:32:35.181963] MINOR: using old style registry for moxas
[Wed May 13 16:32:35 2026] [2026-05-13 16:32:35.181999] INFO: inserting moxa mappings to SQL
[Wed May 13 16:32:35 2026] [2026-05-13 16:32:35.188306] INFO: Connected to moxa details database

@Tom-Willemsen
Copy link
Copy Markdown
Member

Tom-Willemsen commented May 13, 2026

I was mostly paying attention to dbsvr as I'd seen https://github.com/ISISComputingGroup/genie_python_archive/pull/402 in the git blame for why this was pinned in the first place.

Looks like it might just be some API that needs updating along with the version?

@FreddieAkeroyd
Copy link
Copy Markdown
Member Author

FreddieAkeroyd commented May 13, 2026

It did warm me at https://pypi.org/project/pysnmp-lextudio/ but as my dbserver looked to be working I didn't do the version pin pysnmp>=6.2.0,<7.0.0 as suggested initially. Will probably do a flash review to make db server print out an informational message if it finds no moxas as in most cases that would be an error. The inserting moxa mappings to SQL was probably inserting 0 mappings :-D And i'll see how bad the API change is.

@FreddieAkeroyd
Copy link
Copy Markdown
Member Author

OK, now have moxas defined and see the same error as you - looks like dbserver has not been loading old style moxa entries for some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Flash Review

Development

Successfully merging this pull request may close these issues.

3 participants