CHG: Fix bugs in SMBsemic modules and add options for desertification effect and downward longwave radiation.#45
Merged
TidbitSoftware merged 5 commits intoISSMteam:mainfrom Jan 8, 2025
Conversation
Contributor
inwoo-park
commented
Jan 8, 2025
inwoo-park
commented
- Add options for desertification effect and downward longwave radiation correction.
- Fix bug in downward longwave radiation correction in "Elements::SmbSemicTransient".
- Matlab > Python: Add "test246.py".
new file: test/NightlyRun/test246.py
…ection according to "Marty et al. (2002)".
* Fix unit in "md.smb.desfac" (desertification factor): 1/km -> 1/m. * Add options to enable or disable parameterizations for "precipitation desertification" (Vizcaino et al., 2010) and "longwave correction" (Marty et al., 2002) using "md.smb.isdesertification" and "md.smb.isLWDcorret". * Add "SmbSemicIsDesertificationEnum" and "SmbSemicIsLWDcorrectEnum". * Synchronize MATLAB and Python of "src/m/classes/SMBsemic.py" and "src/m/classes/SMBsemic.m". modified: src/c/analyses/SmbAnalysis.cpp modified: src/c/classes/Elements/Element.cpp modified: src/c/shared/Enum/Enum.vim modified: src/c/shared/Enum/EnumDefinitions.h modified: src/c/shared/Enum/EnumToStringx.cpp modified: src/c/shared/Enum/Enumjl.vim modified: src/c/shared/Enum/StringToEnumx.cpp modified: src/c/shared/Enum/issmenums.jl modified: src/m/classes/SMBsemic.m modified: src/m/classes/SMBsemic.py
TidbitSoftware
added a commit
that referenced
this pull request
Jun 10, 2025
CHG: Fix bugs in SMBsemic modules and add options for desertification effect and downward longwave radiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.