Added smb, friction, hydrology to read/write_netCDF#49
Merged
TidbitSoftware merged 4 commits intoISSMteam:mainfrom Feb 2, 2025
Merged
Added smb, friction, hydrology to read/write_netCDF#49TidbitSoftware merged 4 commits intoISSMteam:mainfrom
TidbitSoftware merged 4 commits intoISSMteam:mainfrom
Conversation
TidbitSoftware
added a commit
that referenced
this pull request
Jun 10, 2025
Added smb, friction, hydrology to read/write_netCDF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the inversion example, added functions to write_netCDF.m to check the hydrology/smb/friction class and assign an appropriate name so that read_netCDF.py can change the relevant class in the empty surrogate model and preserve data between matlab and python.
added a later fix to ensure that hydrology.requested_outputs is preserved and not garbled on conversion