OpenCV3.4 Python update #40
Conversation
Updated the functions in the main python file, like the create LBPH recognizer, to be compatible with OpenCV3.4.
Updated the functions in the create_face_model python file, like the create recognizer functions, to be compatible with OpenCV3.4.
| @@ -1,43 +1,15 @@ | |||
| # Human detection and Tracking | |||
There was a problem hiding this comment.
why is title removed from README?
| ```sh | ||
| python3 main.py /video | ||
| ``` | ||
| * To compile the C++ version of the code with openCV the command is: |
There was a problem hiding this comment.
why this whole paragraph is stripped? @YacobBY Can you please explain? the README looks way too much small with little to no information about the project.
There was a problem hiding this comment.
That's a mistake should be put back, is for my personal version.
There was a problem hiding this comment.
Didn't realize it would commit changes I made after submitting the version to you
There was a problem hiding this comment.
please resolve this issue if its a mistake
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| """ |
There was a problem hiding this comment.
what's the improvement in this refactor?
There was a problem hiding this comment.
It's the standard IntelliJ/Pycharm refactor. Personally I think it's more readable like this, but the most important thing is the lbph creation which got changed in OpenCV3.4.
Also might be handy to set the standard path to the video directory in the argparse.
YacobBY
force-pushed
the
master
branch
2 times, most recently
from
adaad0f to
3189003
Compare
|
Readme should be fixed now |
|
Hi, |
|
No you have not solved the issue. People have to manually change the broken code every time. If you fix your code you don't have to deal with people asking the same question over and over. |
|
@YacobBY Sorry about closing the PR. Merged it now. Thanks for your valuable contribution |
3 participants
Updated python code for OpenCV3.4, and readme file for clearer instructions.