Enhancement have 4 outputs #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
reviewed
Sep 15, 2022
src/osparc_python_runner/main.py
Outdated
| def setup(): | ||
| _ensure_output_subfolders() | ||
| logger.info("Processing input from %s:", INPUT_FOLDER) | ||
| logger.info("%s", list(INPUT_FOLDER.glob("*"))) |
Member
There was a problem hiding this comment.
I think it would be more informative to have simply a os.system. See this example
>> import os
>> os.system("ls -la")
total 20
drwxrwxr-x 3 crespo crespo 4096 Sep 15 18:28 .
drwxrwxr-x 3 crespo crespo 4096 Jun 24 2021 ..
-rw-rw-r-- 1 crespo crespo 1312 Sep 15 18:28 input_script_1.py
drwxrwxr-x 2 crespo crespo 4096 Sep 15 18:22 __pycache__
-rw-rw-r-- 1 crespo crespo 20 Sep 15 18:10 requirements.txt
0you can build a context manager to capture the stdout or use something like subprocess.run instead of os.system
src/osparc_python_runner/main.py
Outdated
| logger.info("%s", list(INPUT_FOLDER.glob("*"))) | ||
|
|
||
| # find entrypoint | ||
| user_main_py = _ensure_main_entrypoint(INPUT_FOLDER) |
Member
There was a problem hiding this comment.
MINOR: re-suggesting a name ;-) ... main_input_path
pcrespov
approved these changes
Sep 15, 2022
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
🎉 !! record time!
Please double check my comment with the path before merging ...
Great work!
thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds 3 outputs to the python runner.
Prepare for integration version 1.1.0
Related issue number
How to test
Checklist
make version-service-*