Add extended options, update UI #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CeeRoo
approved these changes
Dec 23, 2024
CeeRoo
left a comment
CeeRoo
left a comment
There was a problem hiding this comment.
Approve-iddly-ooved! Just FYI, there's a commented out section in nu_global_elements.php from line 37 to 59, but maybe that was just to keep a historical reference in the file.
Contributor
Author
Thanks, Chris! Good catch. Just updated with some housekeeping. |
cam-vanorman
requested changes
Dec 23, 2024
Contributor
cam-vanorman
left a comment
cam-vanorman
left a comment
There was a problem hiding this comment.
Small change that Chris mentioned, otherwise this looks great! Thanks Ray!
cam-vanorman
approved these changes
Jan 3, 2025
Contributor
kenwilliams-nu
left a comment
kenwilliams-nu
left a comment
There was a problem hiding this comment.
Awesome, job, Ray!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended options with:
Also updated UI a little bit.