Skip to content

Accordion a11y QA #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenwilliams-nu merged 3 commits into from
May 10, 2023
Merged

Accordion a11y QA #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66c849c
Update composer homepage and authors
cam-vanorman Nov 19, 2022
aad6e3c
Update accordion items with a11y fixes
cam-vanorman Nov 19, 2022
5555311
Update accordion with left icon, remove tabindex from content div
cam-vanorman Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
"northeastern-web",
"support"
],
"homepage": "https://github.com/northeastern-web/kernl-ui-blade",
"homepage": "https://github.com/ITS-Digital-Technology/kernl-ui-blade",
"license": "MIT",
"authors": [
{
"name": "Northeastern Web Solutions",
"name": "Northeastern University ITS Web Solutions",
"email": "websolutions@northeastern.edu",
"homepage": "https://northeastern.edu",
"homepage": "https://its.northeastern.edu",
"role": "Developer"
}
],
Expand Down
1 change: 0 additions & 1 deletion src/views/accordion/item.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class="w-full flex items-center justify-between py-3 px-10 hover:bg-gray-100 foc
x-transition:leave-start="opacity-100 max-h-screen"
x-transition:leave-end="opacity-0 max-h-0 overflow-hidden"
class="h-full overflow-y-auto focus:outline-none focus:ring focus:ring-blue-500"
tabindex="0"
>
<div class="px-10 py-8">
{!! $slot !!}
Expand Down
1 change: 0 additions & 1 deletion src/views/accordion/with-left-icon.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ class="w-full flex items-center py-3 px-10 hover:bg-gray-100 focus:bg-gray-100 f
x-transition:leave-start="opacity-100 max-h-screen"
x-transition:leave-end="opacity-0 max-h-0 overflow-hidden"
class="h-full overflow-y-auto focus:outline-none focus:ring focus:ring-blue-500"
tabindex="0"
>
<div class="px-10 py-8">
{!! $slot !!}
Expand Down