Add bipermutedimsopadd! overloads#152
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 87.33% 87.18% -0.15%
==========================================
Files 20 20
Lines 1263 1264 +1
==========================================
- Hits 1103 1102 -1
- Misses 160 162 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…andles the forwarding)
…ported via using)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to ITensor/TensorAlgebra.jl#158.
bipermutedimsopadd!overloads forAbstractSectorArrayandAbstractGradedArrayas the primary permutation implementation (with fermion phase, block iteration)permutedimsopadd!overloads removed (TensorAlgebra's default flat→biperm forwarding handles them)check_inputdefinitions asTensorAlgebra.check_inputoverloadscheck_input(bipermutedimsopadd!, ...)for generic axes validation in both overloads[sources]to resolve TensorAlgebra from themf/contractopaddbranch (remove before merge, bump compat to 0.9)Breaking changes
None for downstream consumers. This adapts GradedArrays to TensorAlgebra's new
bipermutedimsopadd!primitive.Test plan
mf/contractopaddbranch🤖 Generated with Claude Code