Skip to content

Add bipermutedimsopadd! overloads#152

Merged
mtfishman merged 14 commits into
mainfrom
mf/bipermutedimsopadd
Apr 16, 2026
Merged

Add bipermutedimsopadd! overloads#152
mtfishman merged 14 commits into
mainfrom
mf/bipermutedimsopadd

Conversation

@mtfishman
Copy link
Copy Markdown
Member

@mtfishman mtfishman commented Apr 16, 2026

Summary

Companion PR to ITensor/TensorAlgebra.jl#158.

  • Add bipermutedimsopadd! overloads for AbstractSectorArray and AbstractGradedArray as the primary permutation implementation (with fermion phase, block iteration)
  • Existing permutedimsopadd! overloads removed (TensorAlgebra's default flat→biperm forwarding handles them)
  • Qualify existing check_input definitions as TensorAlgebra.check_input overloads
  • Call check_input(bipermutedimsopadd!, ...) for generic axes validation in both overloads
  • Use [sources] to resolve TensorAlgebra from the mf/contractopadd branch (remove before merge, bump compat to 0.9)
  • Bump version to v0.8.4

Breaking changes

None for downstream consumers. This adapts GradedArrays to TensorAlgebra's new bipermutedimsopadd! primitive.

Test plan

  • All existing tests pass (tensoralgebra, full runtests.jl)
  • Tested against TensorAlgebra.jl mf/contractopadd branch

🤖 Generated with Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.18%. Comparing base (d470cf8) to head (2a4367a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   87.33%   87.18%   -0.15%     
==========================================
  Files          20       20              
  Lines        1263     1264       +1     
==========================================
- Hits         1103     1102       -1     
- Misses        160      162       +2     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman closed this Apr 16, 2026
@mtfishman mtfishman reopened this Apr 16, 2026
@mtfishman mtfishman merged commit 04195a6 into main Apr 16, 2026
19 of 28 checks passed
@mtfishman mtfishman deleted the mf/bipermutedimsopadd branch April 16, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant