Conversation
|
It depends a bit on what we want. This action already has a switch for the format suggestion, which can be enabled with |
|
Let me just check and see if this is actually working, I'll try and get a test repo up and running tomorrow |
|
Seems to all work, ready for merging! (I have no clue why the pre-commit ci keeps reporting failures everywhere, and I don't think I have the permissions to access these settings) https://github.com/ITensor/TestPackage/pull/2 |
The pre-commit.ci check expects a Also I noticed that we will need to update the
Looks great, thanks for getting that set up and double checking it works! |
|
Yes, the update of |
This changes the format checker to use Runic instead of JuliaFormatter.
Importantly however, as we are not using any semantic versioning for our github actions, this more or less means that all format checks across our ecosystem will now start failing until we change all packages to use runic. In principle I'm okay with that because it forces us to go ahead and implement this everywhere, but it is definitely something to consider.