Skip to content

Update formatcheck to use Runic#25

Merged
lkdvos merged 5 commits intomainfrom
runic
Sep 30, 2025
Merged

Update formatcheck to use Runic#25
lkdvos merged 5 commits intomainfrom
runic

Conversation

@lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Sep 28, 2025

This changes the format checker to use Runic instead of JuliaFormatter.

Importantly however, as we are not using any semantic versioning for our github actions, this more or less means that all format checks across our ecosystem will now start failing until we change all packages to use runic. In principle I'm okay with that because it forces us to go ahead and implement this everywhere, but it is definitely something to consider.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Sep 29, 2025

It depends a bit on what we want. This action already has a switch for the format suggestion, which can be enabled with format-suggestions: true and is currently on by default. I can try and play around with the PR version as well, but are we using that anywhere? I am not super excited about fighting with github actions again for this if we aren't using it 😉. I can delete these other actions if you want?

@lkdvos
Copy link
Collaborator Author

lkdvos commented Sep 29, 2025

Let me just check and see if this is actually working, I'll try and get a test repo up and running tomorrow

@lkdvos lkdvos marked this pull request as draft September 29, 2025 21:09
@lkdvos lkdvos marked this pull request as ready for review September 30, 2025 11:13
@lkdvos
Copy link
Collaborator Author

lkdvos commented Sep 30, 2025

Seems to all work, ready for merging! (I have no clue why the pre-commit ci keeps reporting failures everywhere, and I don't think I have the permissions to access these settings)

https://github.com/ITensor/TestPackage/pull/2
https://github.com/ITensor/TestPackage/actions/runs/18127858780/job/51587351483

@lkdvos lkdvos requested a review from mtfishman September 30, 2025 11:14
@mtfishman
Copy link
Member

(I have no clue why the pre-commit ci keeps reporting failures everywhere, and I don't think I have the permissions to access these settings)

The pre-commit.ci check expects a .pre-commit-config.yaml file, i.e. https://github.com/ITensor/BlockSparseArrays.jl/blob/main/.pre-commit-config.yaml, I guess there isn't any harm adding one to this repository (the CI check is slightly annoying since you can either enable it one-by-one in each repository, which is not fun, or run it on every repository in the Github organization, which is fine until there is a repository like this one where we might not need it).

Also I noticed that we will need to update the .pre-commit-config.yamls across all of the repositories to switch them over to Runic: https://github.com/ITensor/BlockSparseArrays.jl/blob/1a474f59f65b7ada867f3fe3e2fb3f3c70c83ed8/.pre-commit-config.yaml#L14.

ITensor/TestPackage#2 https://github.com/ITensor/TestPackage/actions/runs/18127858780/job/51587351483

Looks great, thanks for getting that set up and double checking it works!

@lkdvos
Copy link
Collaborator Author

lkdvos commented Sep 30, 2025

Yes, the update of .pre-commit-config.yml for the packages is part of the update to the skeleton, I'll add a pre-commit here as well then.

@lkdvos lkdvos merged commit b30dc7c into main Sep 30, 2025
1 check passed
@lkdvos lkdvos deleted the runic branch September 30, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants