Narrow test JuliaSyntax compat to match resolver#53
Merged
Conversation
JuliaFormatter 2.3.0 (the latest registered) pins JuliaSyntax to 0.4.10. That transitively forces Runic to downgrade from 1.7 to 1.5.1 (the last Runic compatible with JuliaSyntax 0.4.10). The Check Compat Bounds check was flagging the resulting aspirational claims: - Runic: root compat "1.5.1" (caret, >=1.5.1, <2.0) claimed support up to 1.7.0; resolver only reaches 1.5.1. Narrow to "~1.5.1" (1.5.x). - JuliaSyntax: test compat "0.4.10, 1" claimed support for 1.x; resolver only reaches 0.4.10. Drop the 1.x disjunct. Widen back whenever JuliaFormatter ships a 2.4 release with broader JuliaSyntax compat.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 9 9
Lines 392 392
=======================================
Hits 338 338
Misses 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Under the updated compat-bounds check (ITensorActions#79), within-bucket gaps no longer fail. Runic at 1.5.1 vs 1.7.0 is the same major-1 breaking bucket, so the narrowing from "1.5.1" (caret) to "~1.5.1" is no longer needed. The JuliaSyntax test narrowing (0.4.10 vs 1) stays because it spans breaking buckets. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaFormatter 2.3.0(the latest registered version) pinsJuliaSyntaxto0.4.10. That makestest/Project.toml's entryJuliaSyntax = "0.4.10, 1"aspirational — the1disjunct is never reachable.Under the compat-bounds check's breaking-bucket rule (ITensorActions#79), this spans two buckets (0.4 and 1) and fails the check. Narrowing to
"0.4.10"collapses to a single bucket.Widen back whenever JuliaFormatter ships a release with broader JuliaSyntax compat.
Supersedes