Drop redundant @eval module $(gensym()) wrapper from test files#343
Merged
Drop redundant @eval module $(gensym()) wrapper from test files#343
@eval module $(gensym()) wrapper from test files#343Conversation
`ITensorPkgSkeleton.runtests` already wraps each test file in its own `Module(gensym(:SafeTestset))` (see `_run_isolated_testfile` in ITensorPkgSkeleton). The per-file `@eval module $(gensym())` wrapper at the top of each test file therefore creates a redundant module-inside-a-module. Remove the leading `@eval module $(gensym())` and the matching trailing `end` from all 22 test files that carried it. The four files that already used the bare-module style (`test/test_aqua.jl`, `test/solvers/test_eigsolve.jl`, `test/solvers/test_applyexp.jl`, `test/solvers/test_iterators.jl`) are unchanged. Bump patch version 0.19.3 -> 0.19.4 (test-only diff, substantive per the standard `VersionCheck` classification). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 73.08% 73.11% +0.03%
==========================================
Files 66 66
Lines 3151 3151
==========================================
+ Hits 2303 2304 +1
+ Misses 848 847 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITensorPkgSkeleton.runtestsalready wraps each test file in its ownModule(gensym(:SafeTestset))(see_run_isolated_testfilein ITensorPkgSkeleton). The per-file@eval module $(gensym())wrapper at the top of each test file therefore creates a redundant module-inside-a-module. Remove the leading@eval module $(gensym())and the matching trailingendfrom all 22 test files that carried it.The four files that already used the bare-module style (
test/test_aqua.jl,test/solvers/test_eigsolve.jl,test/solvers/test_applyexp.jl,test/solvers/test_iterators.jl) are unchanged. Bump patch version 0.19.3 -> 0.19.4 (test-only diff, substantive per the standardVersionCheckclassification).