Interface improvements #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 81.73% 79.13% -2.61%
==========================================
Files 9 9
Lines 646 623 -23
==========================================
- Hits 528 493 -35
- Misses 118 130 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Looks good (though it looks like there are now type inference failures in Julia 1.10). |
mtfishman
approved these changes
Nov 12, 2025
Member
|
@lkdvos ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat larger refactor which consists mostly of some code reorganization.
I was having a hard time trying to follow what was going on in the downstream packages, so I wrote some docstrings for the interface functions (which I changed to
kroneckerfactors), and grouped some of the similar code functionality closer together in the source.This way I also now know more or less what is in the package, so this definitely helps for continuing with the gradedarrays updates.