Fix Project.toml: SimpleGraphAlgorithms weakdep, bump julia compat to 1.10#167
Merged
Conversation
…compat to 1.10
SimpleGraphAlgorithms is listed in `[extensions]` as the trigger for
`NamedGraphsSimpleGraphAlgorithmsExt` but was incorrectly declared in
`[deps]` rather than `[weakdeps]`. Pkg on Julia 1.7-1.8 rejects this
configuration ("Expecting a weakdep for SimpleGraphAlgorithms").
Move it to `[weakdeps]` and bump the Julia compat floor to 1.10 (along
with the LinearAlgebra and SparseArrays stdlib pins), matching the rest
of the ITensor ecosystem.
Version stays at 0.11.1: v0.11.1 was never registered (the previous
General registry PR was withdrawn). Re-registration of v0.11.1 against
the corrected Project.toml will be triggered manually post-merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 79.67% 79.67%
=======================================
Files 55 55
Lines 2111 2111
=======================================
Hits 1682 1682
Misses 429 429
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleGraphAlgorithmsfrom[deps]to[weakdeps]. It is listed in[extensions]as the trigger forNamedGraphsSimpleGraphAlgorithmsExt, but having it in[deps]makes Pkg on Julia 1.7–1.8 reject the configuration withExpecting a weakdep for SimpleGraphAlgorithms. The General registry's staging AutoMerge surfaces this on the lowest-compatible-Julia import test.LinearAlgebraandSparseArraysstdlib pins, to match the rest of the ITensor ecosystem.Re-registration of v0.11.1
The version stays at
0.11.1. The previous v0.11.1 registration PR against the General registry was withdrawn before merging, so0.11.1is still available in the registry. After this PR lands, registration of v0.11.1 against the corrected Project.toml will be triggered manually via a/registercomment on the merge commit (the Registrator workflow'sforcepath bypasses the unchanged-version skip guard).Expect
VersionCheckto fail on this PR, since the Project.toml is substantive but the version is intentionally unchanged.